feat(console): allow page.on('console', console.log) #2145

pavelfeldman · 2020-05-07T20:49:33Z

dgozman · 2020-05-07T20:58:50Z

src/console.ts

@@ -52,4 +53,8 @@ export class ConsoleMessage {
  location(): ConsoleMessageLocation {
    return this._location;
  }
+
+  [util.inspect.custom]() {
+    return this.text();


Should we add more details? E.g. [warn] .... @foo.js:15.

Hm. That's not what the regular console.log does in Node though, maybe that should be opt-in?

feat(console): allow page.on('console', console.log)

5b0b2a2

dgozman approved these changes May 7, 2020

View reviewed changes

pavelfeldman merged commit 7a8dd2c into microsoft:master May 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(console): allow page.on('console', console.log) #2145

feat(console): allow page.on('console', console.log) #2145

pavelfeldman commented May 7, 2020 •

edited

dgozman May 7, 2020

pavelfeldman May 7, 2020

feat(console): allow page.on('console', console.log) #2145

feat(console): allow page.on('console', console.log) #2145

Conversation

pavelfeldman commented May 7, 2020 • edited

dgozman May 7, 2020

Choose a reason for hiding this comment

pavelfeldman May 7, 2020

Choose a reason for hiding this comment

pavelfeldman commented May 7, 2020 •

edited