Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser(webkit): expose Playwright.windowOpen signal #2163

Merged
merged 1 commit into from May 9, 2020
Merged

browser(webkit): expose Playwright.windowOpen signal #2163

merged 1 commit into from May 9, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented May 8, 2020

This signal was once introduced, than removed, and now re-introduced again :)

dgozman/WebKit@5f39ad5

yury-s
yury-s approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@yury-s yury-s left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I'd rather try and avoid viewport emulation altogether for popups so that we didn't need to pass the features manually, not sure how feasible is that

@dgozman dgozman merged commit 5b57303 into microsoft:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgozman @yury-s