chore: further unify launching and connection #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
browserType2
branch
from
9f58723
to
0351eee
Compare
dgozman
approved these changes
May 21, 2020
| const browser = await helper.waitWithDeadline(promise, 'the browser to launch', deadline, 'pw:browser*'); | ||
| return browser; | ||
| } catch (e) { | ||
| e.message += '\n=============== Process output during launch: ===============\n' + |
There was a problem hiding this comment.
Should we do this after _closeOrKill to capture it's output as well?
There was a problem hiding this comment.
I don't think so - it adds one more failure point.
| logger.stopLaunchRecording(); | ||
| return browser; | ||
| } catch (e) { | ||
| e.message += '\n=============== Process output during connect: ===============\n' + |
yury-s
approved these changes
May 21, 2020
pavelfeldman
force-pushed
the
browserType2
branch
from
0351eee
to
2a587ba
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.