Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(oopif): race between detachedFromTarget and frameAttached #2419

Merged
merged 1 commit into from Jun 1, 2020
Merged

fix(oopif): race between detachedFromTarget and frameAttached #2419

merged 1 commit into from Jun 1, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented May 30, 2020

During remote -> local transition, these two events come in unpredictable order, so we try to handle both cases.

Also, remote frame detach was not handled at all.

yury-s
yury-s approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can

src/chromium/crPage.ts Outdated Show resolved Hide resolved
@dgozman
fix(oopif): race between detachedFromTarget and frameAttached
3974d35 
During remote -> local transition, these two events come
in unpredictable order, so we try to handle both cases.

Also, remote frame detach was not handled at all.
@dgozman dgozman merged commit 4544110 into microsoft:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgozman @yury-s