feat: support atomic installation of browsers #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Ctrl-C while extracting browser might yield users in a bad place. This patch extracts browsers in a temp directory that is later moved to a installer registry.
dgozman
approved these changes
Jun 5, 2020
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Jun 11, 2020
This reverts 2 commits: - "fix(installer): create tmp directory inside `browserPath` (microsoft#2498)" commit 946b4ef. - "feat: support atomic installation of browsers (microsoft#2489)" commit 3de0c08. This addresses installation issues we see in some CI environments.
aslushnikov
added a commit
that referenced
this pull request
Jun 11, 2020
aslushnikov
added a commit
that referenced
this pull request
Jun 11, 2020
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Jul 17, 2020
Currently, Ctrl-C while extracting browser might yield users in a bad place. This patch adds a marker file inside browser directory to make sure that browser extraction completed. Note: this was already attempted in microsoft#2489, but was eventually reverted in microsoft#2534. References microsoft#2660
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Ctrl-C while extracting browser might yield users in
a bad place.
This patch extracts browsers in a temp directory that is later
moved to the installer registry.