Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: merge{Tests,Expects} via ESM imports #27630

Merged
merged 2 commits into from
Oct 16, 2023
Merged

fix: merge{Tests,Expects} via ESM imports #27630

merged 2 commits into from
Oct 16, 2023

Conversation

mxschmitt
Copy link
Member

Backport to 1.39.X?

Fixes #27617

@github-actions

This comment has been minimized.

Sign in to view
dgozman
dgozman approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test to ttest.

@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › reporter-html.spec.ts:705:5 › merged › should use file-browser friendly extensions for buffer attachments based on contentType

5 flaky ⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:86:1 › should reset serviceworker that hangs in importScripts
⚠️ [webkit] › page/page-goto.spec.ts:266:3 › should fail when navigating to bad SSL

25866 passed, 603 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit fd2fbe9 into microsoft:main Oct 16, 2023
28 of 30 checks passed
@commit-lint commit-lint bot mentioned this pull request Oct 16, 2023
Merged
github-actions bot added a commit that referenced this pull request Oct 16, 2023
@github-actions
cherry-pick(#27630): fix: merge{Tests,Expects} via ESM imports
74ae7e8
mxschmitt pushed a commit that referenced this pull request Oct 17, 2023
@playwrightmachine @github-actions
cherry-pick(#27630): fix: merge{Tests,Expects} via ESM imports (#27641)
0594783 
This PR cherry-picks the following commits:

- fd2fbe9

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
sand4rt pushed a commit to sand4rt/playwright that referenced this pull request Oct 18, 2023
@mxschmitt @sand4rt
fix: merge{Tests,Expects} via ESM imports (microsoft#27630)
ff9f552 
Backport to 1.39.X?

Fixes microsoft#27617
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
@mxschmitt @Germandrummer92
fix: merge{Tests,Expects} via ESM imports (microsoft#27630)
0d61ca8 
Backport to 1.39.X?

Fixes microsoft#27617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] mergeTests does not work with type: "module"
2 participants
@mxschmitt @dgozman