Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expect): Make toPass's option configurable by TestConfig #28231

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

dev-jonghoonpark
Copy link
Contributor

related issue: #23937

Motivation:

Modification:

  • Make expect.toPass options configurable by config file

Result:

@dev-jonghoonpark
Copy link
Contributor Author

@microsoft-github-policy-service agree

This comment has been minimized.

@injae-kim
Copy link

Gentle ping to @mxschmitt, Hi! can you review this PR? many users wait this feature on #23937! 🙇

This comment has been minimized.

@mxschmitt mxschmitt merged commit 4c0a972 into microsoft:main Jan 16, 2024
29 checks passed
Copy link
Contributor

Test results for "tests 1"

2 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-dispatchevent.spec.ts:175:3 › should dispatch device orientation event

18050 passed, 423 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Setup default timeout to expect.toPass assertion
3 participants