fix(firefox): fix launching firefox without dependencies #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Jul 10, 2020
|
Yep, trying! |
yury-s
approved these changes
Jul 10, 2020
| helper.addEventListener(rl, 'close', reject), | ||
| helper.addEventListener(process, 'exit', reject), | ||
| helper.addEventListener(process, 'error', reject) | ||
| helper.addEventListener(rl, 'close', reject.bind(null, failError)), |
We always have to reject promises with some error. Otherwise, our error-rewriting logic in try-catch miserably fails. With this patch, attempt to launch Firefox when it's missing dependencies will actually result in a thrown exception with pretty logs. Without this patch, Playwright throws internal error.
aslushnikov
force-pushed
the
fix-launching-firefox-without-dependencies
branch
from
3399b69
to
8473a14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always have to reject promises with some error. Otherwise,
our error-rewriting logic in try-catch miserably fails.
With this patch, attempt to launch Firefox when it's missing
dependencies will actually result in a thrown exception with
pretty logs. Without this patch, Playwright throws internal error.