fix(chromium): select all on macos should work again #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelEinbinder
force-pushed
the
selectall_mac_again
branch
from
223f83b
to
2e43bac
Compare
aslushnikov
reviewed
Jul 17, 2020
| @@ -50,6 +51,8 @@ export class CRBrowser extends BrowserBase { | |||
| const browser = new CRBrowser(connection, options); | |||
| browser._devtools = devtools; | |||
| const session = connection.rootSession; | |||
| const version = await session.send('Browser.getVersion'); | |||
| browser._isMac = version.userAgent.includes('Macintosh'); | |||
There was a problem hiding this comment.
Is this the remote-first world, i.e. now browser OS might be different from client OS?
There was a problem hiding this comment.
we've always had .connect. Yes
aslushnikov
reviewed
Jul 17, 2020
| constructor( | ||
| private _client: CRSession, | ||
| private _isMac: boolean, | ||
| ) { } |
There was a problem hiding this comment.
fancy ts! what does it do?
There was a problem hiding this comment.
it is a shortcut for:
class Foo {
private bar: number;
constructor(barOpt: number) {
this.bar = barOpt;
}
}There was a problem hiding this comment.
takes an argument in the constructor and immediately sets it as a property. Lets you avoid declaring the type of everything twice and another line to set it.
aslushnikov
reviewed
Jul 17, 2020
| const textarea = await page.$('textarea'); | ||
| await textarea.type('some text'); | ||
| // select one word backwards | ||
| await page.keyboard.press('Shift+Control+Alt+KeyB'); |
aslushnikov
reviewed
Jul 17, 2020
aslushnikov
approved these changes
Jul 17, 2020
pavelfeldman
added a commit
to pavelfeldman/playwright
that referenced
this pull request
Jul 17, 2020
pavelfeldman
added a commit
that referenced
this pull request
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch that enabled this upstream for us got reverted. So we do it ourselves using our own list of macOS editing commands.