feat(addLocatorHandler): various improvements #30494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
reviewed
Apr 24, 2024
This comment has been minimized.
This comment has been minimized.
dgozman
force-pushed
the
feat-locator-handler-improvements
branch
from
6ff22a1
to
c4c1118
Compare
yury-s
approved these changes
Apr 24, 2024
This comment has been minimized.
This comment has been minimized.
dgozman
force-pushed
the
feat-locator-handler-improvements
branch
from
c4c1118
to
6b49d24
Compare
- Automatically waiting for the overlay locator to be hidden, with `allowStayingVisible` opt-out. - `times: 1` option. - `removeLocatorHandler(locator, handler)` method. - Passing `locator` as first argument to `handler`.
dgozman
force-pushed
the
feat-locator-handler-improvements
branch
from
6b49d24
to
d36fbb2
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"3 failed 1 flaky27467 passed, 672 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowStayingVisibleopt-out.times: 1option.removeLocatorHandler(locator, handler)method.locatoras first argument tohandler.Fixes #30471. Fixes #30424. Fixes #29779.