refactor: remove redundant parameters from isElementStyleVisibilityVi… #30637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible Remove the following unnecessary parameters from checkVisibility() in isElementStyleVisibilityVisible: - checkOpacity (historic alias for opacityProperty, defaults to false) - checkVisibilityCSS (historic alias for visibilityProperty, defaults to false) Simplify the function call by removing these obsolete parameters. Signed-off-by: Saswat Das <68921527+dassaswat@users.noreply.github.com>
Test results for "tests 1"2 flaky27282 passed, 671 skipped Merge workflow run. |
thebigbrain
pushed a commit
to thebigbrain/playwright
that referenced
this pull request
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sible
Remove the following unnecessary parameters from checkVisibility() in isElementStyleVisibilityVisible:
Simplify the function call by removing these obsolete parameters.