chore: use monotonic time for sorting #30735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yury-s
commented
May 9, 2024
yury-s
commented
- Use only monotonicTime for sorting, do not use wallTime for that
- Since test runner and the library can be running on different machines, those machines may have clocks which are not synchronized. To avoid problems in such cases we compute delta between test runner and and library contexts based on a start time of action that exists in both contexts.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
May 9, 2024
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"1 flaky27327 passed, 662 skipped Merge workflow run. |
thebigbrain
pushed a commit
to thebigbrain/playwright
that referenced
this pull request
May 12, 2024
* Use only monotonicTime for sorting, do not use wallTime for that * Since test runner and the library can be running on different machines, those machines may have clocks which are not synchronized. To avoid problems in such cases we compute delta between test runner and and library contexts based on a start time of action that exists in both contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.