Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trace-viewer): fix snapshot.html #31033

Merged
merged 1 commit into from
May 28, 2024

Conversation

ruifigueira
Copy link
Contributor

Actual path to get trace contexts is /contexts, not /context

Actual path to get trace contexts is /contexts, not /context

This comment has been minimized.

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, great catch! The fix looks good, but the bots were unhappy. I've restarted the failed ones, because it looked more like infra failure. If the tests pass, I'll merge this in.

Copy link
Contributor

Test results for "tests 1"

2 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:240:1 › should have network requests
⚠️ [webkit-page] › page/workers.spec.ts:243:3 › should support offline

27067 passed, 609 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit f254290 into microsoft:main May 28, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants