Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webkit): roll to r2014 #31059

Closed
wants to merge 1 commit into from
Closed

feat(webkit): roll to r2014 #31059

wants to merge 1 commit into from

Conversation

playwrightmachine
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

30 failed
❌ [playwright-test] › watch.spec.ts:641:5 › should run CT on changed deps
❌ [playwright-test] › watch.spec.ts:681:5 › should run CT on indirect deps change
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:22:3 › should work @smoke
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:87:3 › should send cookie header
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:99:3 › should isolate cookies in browser contexts
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:161:3 › should isolate send cookie header
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:197:3 › should set multiple cookies
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:217:3 › should have |expires| set to |-1| for session cookies
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:227:3 › should set cookie with reasonable defaults
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:309:3 › should be able to set unsecure cookie for HTTP website
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:342:3 › should set cookies for a frame
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:428:3 › should allow unnamed cookies
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:20:3 › should clear cookies
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:34:3 › should isolate cookies when clearing
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:52:3 › should remove cookies by name
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:72:3 › should remove cookies by name regex
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:116:3 › should remove cookies by path
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:24:3 › should get a cookie @smoke
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:43:3 › should get a non-session cookie
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:112:3 › should get multiple cookies
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:353:3 › should support requestStorageAccess
❌ [webkit-library] › library/browsercontext-fetch.spec.ts:1205:3 › should support set-cookie with SameSite and without Secure attribute over HTTP
❌ [webkit-library] › library/browsercontext-route.spec.ts:112:3 › should support Set-Cookie header
❌ [webkit-library] › library/browsercontext-route.spec.ts:155:3 › should use Set-Cookie header in future requests
❌ [webkit-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work @smoke
❌ [webkit-library] › library/defaultbrowsercontext-1.spec.ts:64:3 › context.clearCookies() should work
❌ [webkit-library] › library/har.spec.ts:192:3 › should include cookies
❌ [playwright-test] › reporter.spec.ts:250:9 › created › should not have internal error when steps are finished after timeout

2 flaky ⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots

26380 passed, 604 skipped
✔️✔️✔️

Merge workflow run.

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 2"

6 fatal errors, not part of any test
112 failed
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:22:3 › should work @smoke
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:87:3 › should send cookie header
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:99:3 › should isolate cookies in browser contexts
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:161:3 › should isolate send cookie header
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:197:3 › should set multiple cookies
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:217:3 › should have |expires| set to |-1| for session cookies
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:227:3 › should set cookie with reasonable defaults
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:309:3 › should be able to set unsecure cookie for HTTP website
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:342:3 › should set cookies for a frame
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:428:3 › should allow unnamed cookies
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:20:3 › should clear cookies
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:34:3 › should isolate cookies when clearing
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:52:3 › should remove cookies by name
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:72:3 › should remove cookies by name regex
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:116:3 › should remove cookies by path
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:24:3 › should get a cookie @smoke
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:43:3 › should get a non-session cookie
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:112:3 › should get multiple cookies
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:353:3 › should support requestStorageAccess
❌ [webkit-library] › library/browsercontext-fetch.spec.ts:1205:3 › should support set-cookie with SameSite and without Secure attribute over HTTP
❌ [webkit-library] › library/browsercontext-route.spec.ts:112:3 › should support Set-Cookie header
❌ [webkit-library] › library/browsercontext-route.spec.ts:155:3 › should use Set-Cookie header in future requests
❌ [webkit-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work @smoke
❌ [webkit-library] › library/defaultbrowsercontext-1.spec.ts:64:3 › context.clearCookies() should work
❌ [webkit-library] › library/har.spec.ts:192:3 › should include cookies
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:22:3 › should work @smoke
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:87:3 › should send cookie header
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:99:3 › should isolate cookies in browser contexts
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:161:3 › should isolate send cookie header
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:197:3 › should set multiple cookies
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:217:3 › should have |expires| set to |-1| for session cookies
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:227:3 › should set cookie with reasonable defaults
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:309:3 › should be able to set unsecure cookie for HTTP website
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:342:3 › should set cookies for a frame
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:428:3 › should allow unnamed cookies
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:20:3 › should clear cookies
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:34:3 › should isolate cookies when clearing
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:52:3 › should remove cookies by name
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:72:3 › should remove cookies by name regex
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:116:3 › should remove cookies by path
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:24:3 › should get a cookie @smoke
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:43:3 › should get a non-session cookie
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:112:3 › should get multiple cookies
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:353:3 › should support requestStorageAccess
❌ [webkit-library] › library/browsercontext-fetch.spec.ts:1205:3 › should support set-cookie with SameSite and without Secure attribute over HTTP
❌ [webkit-library] › library/browsercontext-route.spec.ts:112:3 › should support Set-Cookie header
❌ [webkit-library] › library/browsercontext-route.spec.ts:155:3 › should use Set-Cookie header in future requests
❌ [webkit-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work @smoke
❌ [webkit-library] › library/defaultbrowsercontext-1.spec.ts:64:3 › context.clearCookies() should work
❌ [webkit-library] › library/har.spec.ts:192:3 › should include cookies
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:22:3 › should work @smoke
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:87:3 › should send cookie header
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:99:3 › should isolate cookies in browser contexts
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:161:3 › should isolate send cookie header
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:197:3 › should set multiple cookies
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:217:3 › should have |expires| set to |-1| for session cookies
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:227:3 › should set cookie with reasonable defaults
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:309:3 › should be able to set unsecure cookie for HTTP website
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:342:3 › should set cookies for a frame
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:428:3 › should allow unnamed cookies
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:20:3 › should clear cookies
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:34:3 › should isolate cookies when clearing
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:52:3 › should remove cookies by name
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:72:3 › should remove cookies by name regex
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:116:3 › should remove cookies by path
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:24:3 › should get a cookie @smoke
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:43:3 › should get a non-session cookie
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:112:3 › should get multiple cookies
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:353:3 › should support requestStorageAccess
❌ [webkit-library] › library/browsercontext-fetch.spec.ts:1205:3 › should support set-cookie with SameSite and without Secure attribute over HTTP
❌ [webkit-library] › library/browsercontext-route.spec.ts:112:3 › should support Set-Cookie header
❌ [webkit-library] › library/browsercontext-route.spec.ts:155:3 › should use Set-Cookie header in future requests
❌ [webkit-library] › library/browsertype-connect.spec.ts:711:5 › launchServer › setInputFiles should preserve lastModified timestamp
❌ [webkit-library] › library/browsertype-connect.spec.ts:711:5 › run-server › setInputFiles should preserve lastModified timestamp
❌ [webkit-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work @smoke
❌ [webkit-library] › library/defaultbrowsercontext-1.spec.ts:64:3 › context.clearCookies() should work
❌ [webkit-library] › library/har.spec.ts:192:3 › should include cookies
❌ [webkit-page] › page/page-set-input-files.spec.ts:680:3 › should preserve lastModified timestamp
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:22:3 › should work @smoke
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:87:3 › should send cookie header
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:99:3 › should isolate cookies in browser contexts
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:161:3 › should isolate send cookie header
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:197:3 › should set multiple cookies
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:217:3 › should have |expires| set to |-1| for session cookies
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:227:3 › should set cookie with reasonable defaults
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:309:3 › should be able to set unsecure cookie for HTTP website
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:342:3 › should set cookies for a frame
❌ [webkit-library] › library/browsercontext-add-cookies.spec.ts:428:3 › should allow unnamed cookies
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:20:3 › should clear cookies
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:34:3 › should isolate cookies when clearing
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:52:3 › should remove cookies by name
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:72:3 › should remove cookies by name regex
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:116:3 › should remove cookies by path
❌ [webkit-library] › library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:24:3 › should get a cookie @smoke
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:43:3 › should get a non-session cookie
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:112:3 › should get multiple cookies
❌ [webkit-library] › library/browsercontext-cookies.spec.ts:353:3 › should support requestStorageAccess
❌ [webkit-library] › library/browsercontext-fetch.spec.ts:1205:3 › should support set-cookie with SameSite and without Secure attribute over HTTP
❌ [webkit-library] › library/browsercontext-route.spec.ts:112:3 › should support Set-Cookie header
❌ [webkit-library] › library/browsercontext-route.spec.ts:155:3 › should use Set-Cookie header in future requests
❌ [webkit-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work @smoke
❌ [webkit-library] › library/defaultbrowsercontext-1.spec.ts:64:3 › context.clearCookies() should work
❌ [webkit-library] › library/har.spec.ts:192:3 › should include cookies

57 flaky ⚠️ [chromium-library] › library/browsertype-connect.spec.ts:844:7 › run-server › socks proxy › should proxy based on the pattern
⚠️ [chromium-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [chromium-page] › page/locator-misc-1.spec.ts:28:3 › should hover when Node is removed
⚠️ [chromium-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [chromium-page] › page/page-mouse.spec.ts:193:3 › should trigger hover state with removed window.Node
⚠️ [chromium-page] › page/page-drag.spec.ts:53:5 › Drag and drop › should not send dragover on the first mousemove
⚠️ [chromium-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox-page] › page/page-click.spec.ts:232:3 › should click on checkbox input and toggle
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [firefox-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:58:3 › should not hang with touch-enabled viewports
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages
⚠️ [firefox-library] › library/hit-target.spec.ts:398:3 › should click in iframe with padding
⚠️ [firefox-library] › library/selector-generator.spec.ts:385:5 › selector generator › should use the name attributes for elements that can have it
⚠️ [firefox-library] › library/tracing.spec.ts:292:5 › should overwrite existing file
⚠️ [firefox-page] › page/page-click.spec.ts:99:3 › should click the 1x1 div
⚠️ [firefox-library] › library/tracing.spec.ts:412:14 › should produce screencast frames crop
⚠️ [firefox-page] › page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy
⚠️ [chromium-page] › page/page-event-request.spec.ts:139:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium-library] › library/capabilities.spec.ts:141:3 › should not crash on showDirectoryPicker
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:341:5 › launchServer › should throw when calling waitForNavigation after disconnect
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:711:5 › run-server › setInputFiles should preserve lastModified timestamp
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:101:5 › launch server › should log protocol
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session
⚠️ [chromium-library] › library/har.spec.ts:82:3 › should have pages in persistent context
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should work with --save-har
⚠️ [chromium-library] › library/tracing.spec.ts:350:5 › should survive browser.close with auto-created traces dir
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium-page] › page/locator-misc-1.spec.ts:21:3 › should hover @smoke
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [chromium-page] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [chromium-page] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:86:1 › should reset serviceworker that hangs in importScripts
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:56:7 › cli codegen › should ignore programmatic events
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:76:7 › cli codegen › should click after same-document navigation
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:626:7 › cli codegen › should await popup
⚠️ [webkit-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [webkit-page] › page/page-wait-for-navigation.spec.ts:85:3 › should work with clicking on links which do not commit navigation
⚠️ [webkit-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:341:7 › cli codegen › should press
⚠️ [webkit-library] › library/tap.spec.ts:23:3 › should send all of the correct events @smoke
⚠️ [webkit-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [webkit-page] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [webkit-page] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [webkit-page] › page/page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [webkit-library] › library/inspector/cli-codegen-java.spec.ts:92:5 › should work with --save-har
⚠️ [webkit-page] › page/workers.spec.ts:243:3 › should support offline

173023 passed, 7644 skipped, 2643 did not run
✔️✔️✔️

Merge workflow run.

@yury-s yury-s mentioned this pull request May 29, 2024
Merged
yury-s added a commit that referenced this pull request May 30, 2024
@yury-s
feat(webkit): roll to r2014 (#31074)
f93da40 
Closes #31059
Closes #31012

Reference microsoft/playwright-browsers#795
@mxschmitt mxschmitt deleted the roll-into-pw-webkit/2014 branch June 3, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CQ1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@playwrightmachine