feat(ct): expose msw fixture that accepts msw-style request handlers
#31154
+415
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Jun 5, 2024
Implemented on top of `context.route()`.
Test results for "tests 1"15 passed Merge workflow run. |
kettanaito
reviewed
Jun 8, 2024
| } | ||
| } | ||
|
|
||
| async function globalFetch(...args: Parameters<typeof globalThis.fetch>) { |
There was a problem hiding this comment.
If you add msw as a dependency, it exposes the getResponse function that you can reuse here. Less logic duplication.
kettanaito
reviewed
Jun 8, 2024
| run(args: { request: Request, resolutionContext: { baseUrl?: string }, requestId: string }): Promise<{ response: Response } | undefined>; | ||
| } | ||
|
|
||
| export interface MSW { |
There was a problem hiding this comment.
Would be nice to actually import { RequestHandler } from 'msw'.
|
I have some concerns about this. Please see #30981. TL;DR I'd rather people used the same MSW experience than a compatible API. MSW works great in any browser, including browsers automated by Playwright. I see no reason to diverge the behavior, losing a significant chunk of MSW's benefits along the way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented on top of
context.route().