fix(screenshotter): only wait for for document.fonts.ready on locator frame / page main frame #31295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
waiting-for-fonts-screenshotter
branch
from
f1f149c
to
3fb6fee
Compare
mxschmitt
changed the title
Test results for "tests 1"3 failed 28344 passed, 636 skipped Merge workflow run. |
dgozman
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigation
We usenonStallingEvaluateInExistingContextas of today, which doeseval()inside (from our utilityScript) which breaks for some sites. It causes a hang, since the returnedPromiseofeval()hangs. We don't know as of today why this happens. Without wrapping it inieval()it does not hang.Workaround: Do a plain Runtime.evaluate instead.workaround: Only wait on main frame.
Relates #28995 (keeping it open until they confirm that it helps)