Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump ws from 8.16.0 to 8.17.1 #31377

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 18, 2024

Bumps ws from 8.16.0 to 8.17.1.

Release notes

Sourced from ws's releases.

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the [--max-http-header-size=size][] and/or the [maxHeaderSize][] options so that no more headers than the server.maxHeadersCount limit can be sent.

... (truncated)

Commits
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • 934c9d6 [ci] Test on node 22
  • 1817bac [ci] Do not test on node 21
  • 96c9b3d [major] Flip the default value of allowSynchronousEvents (#2221)
  • e5f32c7 [fix] Emit at most one event per event loop iteration (#2218)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [ws](https://github.com/websockets/ws) from 8.16.0 to 8.17.1.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.16.0...8.17.1)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 18, 2024
Copy link
Contributor

Test results for "tests 1"

1 flaky ⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots

28362 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

This comment has been minimized.

Copy link
Contributor

Test results for "tests 2"

2 fatal errors, not part of any test
5 failed
❌ [chromium-page] › page/page-set-input-files.spec.ts:40:3 › should upload a folder
❌ [chromium-page] › page/page-set-input-files.spec.ts:40:3 › should upload a folder
❌ [chromium-page] › page/page-set-input-files.spec.ts:40:3 › should upload a folder
❌ [chromium-library] › library/browsertype-connect.spec.ts:642:5 › run-server › should fulfill with global fetch result
❌ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work

59 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:241:1 › should have network requests
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:80:5 › launchServer › should connect over wss
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:642:5 › run-server › should fulfill with global fetch result
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work
⚠️ [chromium-library] › library/har.spec.ts:82:3 › should have pages in persistent context
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har
⚠️ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address
⚠️ [chromium-page] › page/page-mouse.spec.ts:193:3 › should trigger hover state with removed window.Node
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:383:7 › cli codegen › should generate getByTestId
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:604:7 › PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS=1 › setOffline
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:200:7 › cli codegen › should download files
⚠️ [chromium-library] › library/video.spec.ts:382:5 › screencast › should capture navigation
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:139:3 › should upload large file
⚠️ [chromium-page] › page/page-event-request.spec.ts:110:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium-page] › page/page-event-request.spec.ts:110:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox-page] › page/locator-misc-1.spec.ts:28:3 › should hover when Node is removed
⚠️ [firefox-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:35:3 › frame.focus should work multiple times
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:46:3 › should click with disabled javascript
⚠️ [firefox-library] › library/capabilities.spec.ts:171:3 › navigator.clipboard should be present
⚠️ [firefox-library] › library/hit-target.spec.ts:24:3 › should block all events when hit target is wrong
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:375:7 › cli codegen › should update selected element after pressing Tab
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:138:7 › cli codegen › should upload multiple files
⚠️ [firefox-library] › library/inspector/cli-codegen-java.spec.ts:107:5 › should print the correct imports in junit
⚠️ [firefox-library] › library/selector-generator.spec.ts:444:5 › selector generator › should ignore empty data-test-id for candidate consideration
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1114:1 › should highlight locator in iframe while typing
⚠️ [firefox-library] › library/tracing.spec.ts:292:5 › should overwrite existing file
⚠️ [firefox-page] › page/page-click.spec.ts:97:3 › should click the 1x1 div
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:30:3 › context request should pick up proxy credentials
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1167:3 › should work with connectOverCDP
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:328:5 › run-server › should throw when used after isConnected returns false
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:70:5 › should cleanup artifacts dir after connectOverCDP disconnects due to ws close
⚠️ [chromium-library] › library/downloads-path.spec.ts:32:5 › downloads path › should keep downloadsPath folder
⚠️ [chromium-library] › library/har.spec.ts:82:3 › should have pages in persistent context
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should work with --save-har
⚠️ [chromium-page] › page/page-mouse.spec.ts:186:3 › should trigger hover state on disabled button
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:24:7 › cli codegen › should contain open page
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:553:7 › cli codegen › should select
⚠️ [webkit-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should work with --save-har
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:276:7 › cli codegen › should handle dialogs
⚠️ [webkit-page] › page/page-click.spec.ts:230:3 › should click on checkbox input and toggle
⚠️ [webkit-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:197:7 › cli codegen › should not target selector preview by text regexp
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:292:7 › cli codegen › should fill textarea
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:292:7 › cli codegen › should fill textarea
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:518:7 › cli codegen › should fill tricky characters
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:442:7 › cli codegen › should reset hover model on action when element detaches
⚠️ [webkit-library] › library/tap.spec.ts:23:3 › should send all of the correct events @smoke
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:99:5 › mobile viewport › should fire orientationchange event
⚠️ [webkit-page] › page/workers.spec.ts:243:3 › should support offline

220205 passed, 9624 skipped, 1355 did not run
✔️✔️✔️

Merge workflow run.

This comment has been minimized.

Copy link
Contributor

Test results for "tests others"

2 failed
❌ [playwright-test] › reporter-html.spec.ts:296:5 › created › should include image diff when screenshot failed to generate due to animation
❌ [playwright-test] › ui-mode-test-setup.spec.ts:217:9 › web-mode: true › should run teardown with SIGINT

2 flaky ⚠️ [electron-api] › electron/electron-app.spec.ts:55:5 › should fire close event when the app quits itself
⚠️ [electron-page] › page/page-screenshot.spec.ts:892:3 › should throw if screenshot size is too large

15707 passed, 530 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit 82a44f2 into main Jun 19, 2024
170 of 188 checks passed
@dgozman dgozman deleted the dependabot/npm_and_yarn/ws-8.17.1 branch June 19, 2024 17:42
dgozman added a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant