refactor(ui): some react refactorings #31900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Interestingly, it looks like the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Skn0tt
force-pushed
the
react-refactor-context
branch
2 times, most recently
from
f4cbe0d
to
cce3d54
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The vite/react plugin automatically inserts this import, so there's no need to have it in JSX files if it isn't used to import hooks. https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/README.md#jsxruntime
dont use @web
Skn0tt
force-pushed
the
react-refactor-context
branch
from
7890043
to
e80a6b5
Compare
dgozman
approved these changes
Jul 31, 2024
mxschmitt
approved these changes
Jul 31, 2024
Test results for "tests 1"3 flaky29510 passed, 702 skipped Merge workflow run. |
Skn0tt
added a commit
that referenced
this pull request
Jul 31, 2024
…dren into named properties (#31925) Pulled out from #31900 I stumbled over `React.Children`, because it's the first time I saw that used. https://react.dev/reference/react/Children lists `React.Children` it as "Legacy" and mentions it's uncommon. Also, the fact that SplitView only displays its first two children, and all others are silently discarded, can be a surprise to some. By separating things out into `sidebar` and `main`, not only do we give the two elements names (otherwise one needs to remember that sidebar is always the first child), but we also prevent any "third children" from being dropped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #31863. This PR is chonky, but the individual commits should be easy to review. If they're not, i'm happy to break them out into individual PRs.
There's two main things this does:
clsx-inspired helper function for classname templatingI wasn't able to replace
ReactDOM.renderwithReactDOM.createRoot. This is the new recommended way starting with React 18, and the existing one is going to be deprecated at some point. But it somehow breaks our tests, i'll have to investigate that separately.