browser(firefox): start screencast in existing pages upon setScreencastOptions #4045
Conversation
…stOptions This makes it work in persistent context. To achieve this, we have to move screencast logic into PageTarget and make PageHandler listen to an event.
|
Why didn't it work today? |
There was a problem hiding this comment.
I'd rather change our default context logic to manually create first page, it would allow to get rid of this workaround as well as hairy logic in _loadDefaultContext. This is a bigger cross-browser change though so we can probably live with the status quo for longer.
With persistent context browser creates first page which may happen before setScreencastOptions take effect. I believe this is a general problem that first page in default context may not inherit some of the context properties. |
Yeah, we can put this into our backlog 😄 |
This makes it work in persistent context.
To achieve this, we have to move screencast logic into PageTarget and
make PageHandler listen to an event.
References #3996.