browser(webkit): Input.dispatchTapEvent #4102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
yury-s
approved these changes
Oct 9, 2020
JoelEinbinder
force-pushed
the
wk_tap_impl
branch
from
60ca0fc
to
54752db
Compare
JoelEinbinder
force-pushed
the
wk_tap_impl
branch
from
54752db
to
2b850d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a protocol method to dispatch tap events. Some code from the iOS port is copied over to correctly handle pointer events. There is some missing logic around when iOS does and does not dispatch the fake mouse events, but I will add that in a follow up. Right now it just behaves like chrome and firefox and always sends fake mouse events.
JoelEinbinder/webkit@3975f80