feat: remove all environment variables and references to puppeteer-core #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pavelfeldman
approved these changes
Nov 22, 2019
This was referenced May 14, 2020
This was referenced May 21, 2020
sand4rt
pushed a commit
to sand4rt/playwright
that referenced
this pull request
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment variables we inherited from puppeteer well as puppeteer-core don't necessarily make sense when considering multiple browsers.
This patch removes everything, so that we have a blank slate on which to figure out our npm story.
install.js now only contains code that should be run for the github checkout, so I added it to .npmignore.