test: fixed failing test on video bot #4747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Dec 17, 2020
mxschmitt
force-pushed
the
bugfix/video-tests
branch
from
bcff7f0
to
3ab2206
Compare
do you have an idea why this change needs to be reverted? Weird behaviour for me, even that this is passing with the normal tests. |
No, not really. Probably needs investigation. |
mxschmitt
force-pushed
the
bugfix/video-tests
branch
from
85dd374
to
3ab2206
Compare
|
Should we land this? |
Would say yes, reverted the relevant changes which I did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by #4736 reverted my change.
@dgozman (#4736 (comment))