feat(installer): retry download if connection is interrupted #5126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Jan 23, 2021
|
Why is it specific to ECONRESET? |
dgozman
reviewed
Jan 25, 2021
| @@ -173,7 +173,18 @@ export async function downloadBrowserWithProgressBar(browsersPath: string, brows | |||
| const url = revisionURL(browser); | |||
| const zipPath = path.join(os.tmpdir(), `playwright-download-${browser.name}-${browserPaths.hostPlatform}-${browser.revision}.zip`); | |||
| try { | |||
| await downloadFile(url, zipPath, progress); | |||
| for (let attempt = 1, N = 3; attempt <= N; ++attempt) { | |||
| const {error} = await downloadFile(url, zipPath, progress); | |||
There was a problem hiding this comment.
Why not try/catch instead? Are you sure we are not getting errors anywhere else? Like, from fs.createWriteStream for example?
There was a problem hiding this comment.
there's a try-catch around to handle this case. We don't want to re-try in case of write stream error though since it's hard to predict consequences.
dgozman
approved these changes
Jan 27, 2021
aslushnikov
force-pushed
the
retry-browser-download-if-network-is-intermittent
branch
from
0d33efb
to
68fb8f0
Compare
aslushnikov
deleted the
retry-browser-download-if-network-is-intermittent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5110