chore: move recorder to server side #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Jan 23, 2021
src/client/browserContext.ts
Outdated
| @@ -255,8 +254,12 @@ export class BrowserContext extends ChannelOwner<channels.BrowserContextChannel, | |||
| } | |||
| } | |||
|
|
|||
| async _extendInjectedScript<Arg>(source: string, arg?: Arg) { | |||
| await this._channel.extendInjectedScript({ source, arg: serializeArgument(arg) }); | |||
| async _exposeConsoleApi<Arg>() { | |||
There was a problem hiding this comment.
nit: no need for <Arg> here and below
src/server/browserContext.ts
Outdated
| await this._extendInjectedScript(recorderSource.source); | ||
| } | ||
|
|
||
| private async _extendInjectedScript(name: string, arg?: any) { |
pavelfeldman
force-pushed
the
extend_script
branch
from
2ec92ef
to
eb9c697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.