Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Python to docker images #5139

Merged

Conversation

aslushnikov
Copy link
Collaborator

This adds +100MB to network transfer size but enables our
users to use playwright-python from-inside docker container.

Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about bionic image?

@mxschmitt
Copy link
Member

mxschmitt commented Jan 25, 2021

Is the package-lock.json change intended?

Also not sure about the handling there so how Java, C# would handle that, should that also be added as a dependency to the image?

@aslushnikov aslushnikov force-pushed the add-python-to-focal-docker-image branch from 0b11480 to 168b00c Compare January 27, 2021 16:45
@aslushnikov aslushnikov changed the title chore: add Python to Dockerimage.focal chore: add Python to docker images Jan 27, 2021
@aslushnikov
Copy link
Collaborator Author

What about bionic image?

@yurys I originally thought that it's hard to get Python 3.8 on bionic, but turns out it's not. Added it as well.

Is the package-lock.json change intended?

These are reverted!

Also not sure about the handling there so how Java, C# would handle that, should that also be added as a dependency to the image?

There are no plans to add these to the image atm, and there's not much interest for that. This is a shortcut for us to get python running without too much investment.

Also, there are some discussions on monorepoing everything. If this happens, it'll simplify management and we'll be able to have multiple images next to each other.

This adds +100MB to network transfer size but enables our
users to use playwright-python from-inside docker container.
@aslushnikov aslushnikov force-pushed the add-python-to-focal-docker-image branch from b3fbd79 to 1c319f8 Compare January 27, 2021 16:51
@aslushnikov aslushnikov merged commit 9de0a5a into microsoft:master Jan 27, 2021
@aslushnikov aslushnikov deleted the add-python-to-focal-docker-image branch January 27, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants