Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: support argument overrides #5200

Merged
merged 4 commits into from Jan 29, 2021
Merged

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Jan 28, 2021

  • Supported parameter overrides - default definition can can replaced by a language specific one. Override is matched with the default definition by either name or alias. This ensures that overriding parameter always goes in the same order as the default one,.
  • Inverted pageFunction parameter definition: js is now an override, python version became default
  • Use separate if for force_expression in python to avoid confusion

Corresponding change to the docs site: microsoft/playwright.dev#93

docs/src/api/javascript.md Outdated Show resolved Hide resolved
docs/src/api/params.md Outdated Show resolved Hide resolved
utils/doclint/api_parser.js Outdated Show resolved Hide resolved
utils/doclint/api_parser.js Outdated Show resolved Hide resolved
utils/doclint/api_parser.js Show resolved Hide resolved
utils/doclint/generateApiJson.js Outdated Show resolved Hide resolved
utils/doclint/documentation.js Outdated Show resolved Hide resolved
@yury-s yury-s merged commit 21041bc into microsoft:master Jan 29, 2021
@yury-s yury-s deleted the docs-arg-override branch January 29, 2021 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants