feat(snapshots): incremental snapshots #5213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch from html to json ml format. - Allow node reuse between snapshots with `[nSnapshotsBefore, nodeWithIndexM]`. - Service worker now lazily serializes snapshot chunks into a single html. This decreases total snapshot size on random scripts ~10x. This also decreases snapshot collecting time on mostly static pages to ~0.3ms. Unfortunate downside for now is that we have to intercept `Element.prototype.attachShadow` to invalidate nodes. This also temporary breaks scroll restoration. Needs more research.
pavelfeldman
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[nSnapshotsBefore, nodeWithIndexM].This decreases total snapshot size on random scripts ~10x.
This also decreases snapshot collecting time on mostly static pages to ~0.3ms.
Unfortunate downside for now is that we have to intercept
Element.prototype.attachShadowto invalidate nodes. Thisalso temporary breaks scroll restoration. Needs more research.