Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(csharp): events convention based naming fix for csharp #5238

Merged
merged 3 commits into from Feb 4, 2021
Merged

docs(csharp): events convention based naming fix for csharp #5238

merged 3 commits into from Feb 4, 2021

Conversation

avodovnik
Copy link
Contributor

Updating some event names to match the expected convention in dotnet land.

Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also swap the defaults here and lowercase event names in JavaScript and Python, because lowercasing is lossy. Then we again have no aliases.

@avodovnik
Copy link
Contributor Author

We should also swap the defaults here and lowercase event names in JavaScript and Python, because lowercasing is lossy. Then we again have no aliases.

Did you mean lowercasing them at generation time? Or just having a alias-js like with the other PR?

docs/src/api/class-websocket.md Outdated Show resolved Hide resolved
utils/generate_types/index.js Show resolved Hide resolved
docs/src/multi-pages.md Outdated Show resolved Hide resolved
@avodovnik
Copy link
Contributor Author

Linting will fail until this gets merged: #5309

@avodovnik avodovnik merged commit ff06399 into microsoft:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants