feat: download ffmpeg during install step #5249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
changed the title
dgozman
reviewed
Feb 2, 2021
| super(packagePath, browser, playwrightOptions); | ||
|
|
||
| const browsersPath = browserPaths.browsersPath(packagePath); |
There was a problem hiding this comment.
Let's put everything we need in PlaywrightOptions or somewhere close, and introduce a helper method that will retrieve all the paths on demand? I feel like we have too much juggling with browserPaths scattered across the codebase.
| @@ -95,6 +96,20 @@ function getDownloadUrl(browserName: BrowserName, revision: number, platform: Br | |||
| ['win64', '%s/builds/webkit/%s/webkit-win64.zip'], | |||
| ]).get(platform); | |||
| } | |||
|
|
|||
| if (browserName === 'ffmpeg') { | |||
There was a problem hiding this comment.
I think we now have to compress our "downloading foo..." spam into a single "downloading..." item.
dgozman
approved these changes
Feb 3, 2021
This patch starts downloading FFMPEG like we download our browsers instead of bundling it in the NPM package. With this patch, NPM size is reduced from 8.8MB to 1.7MB. Consequences: - `npx playwright` is drastically faster now - playwright driver for language bindings is way smaller - projects that bundle Playwright can pass Apple Notorization Fixes microsoft#5193
aslushnikov
force-pushed
the
download-ffmpeg-during-install-step
branch
from
a9cb5cf
to
be7f2ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch starts downloading FFMPEG like we download our browsers
instead of bundling it in the NPM package.
With this patch, NPM size is reduced from 8.8MB to 1.7MB.
Consequences:
npx playwrightis drastically faster nowFixes #5193