feat(dialogs): auto-dismiss dialogs when there are no listeners #5269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes dialogs disappear and prevents stalling. Pros: - No need to worry about dialogs for most users. - Those that wait for a specific dialog still get to control it. Cons: - Those who use Playwright to show interactive browser will have to add an empty 'dialog' handler to prevent auto-dismiss. We do this in cli.
yury-s
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes dialogs disappear and prevents stalling.
Pros:
Cons:
to add an empty 'dialog' handler to prevent auto-dismiss.
We do this in cli.
Fixes #5134.