feat: auto-detect expression/function in js server #5284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Feb 3, 2021
| // This means we might have a function shorthand. Try another | ||
| // time prefixing 'function '. | ||
| if (expression.startsWith('async ')) | ||
| expression = 'async function ' + expression.substring('async '.length); |
There was a problem hiding this comment.
I'd move this to the js client where we now if it's a function or not and just need to update the serialization logic to replace the prefix if needed. Could be done separately.
There was a problem hiding this comment.
I need to patch 10 call sites for that :/
dgozman
approved these changes
Feb 3, 2021
pavelfeldman
force-pushed
the
isFunction
branch
from
e4404e2
to
e6a4439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.