docs: define java specific waitFor* methods #5315
Conversation
yury-s
requested review from
pavelfeldman and
dgozman
and removed request for
pavelfeldman
docs/src/api/java.md
Outdated
|
|
||
| ### param: Page.waitForFrameNavigated.callback = %%-java-wait-for-event-callback-%% | ||
|
|
||
| ## method: Page.waitForPageError |
There was a problem hiding this comment.
Maybe we don't need this one?
Also, I am not sure about waitForFrameAttached, waitForFrameDetached, waitForRequestFailed/Finished, waitForSocketError.
There was a problem hiding this comment.
Well, it is actually used in TestWorker.shouldReportErrors test today, without it the test would be more cumbersome. Same with waitForRequestFailed. waitForFrameAttached does as much sense as the frameAttached event itself, so I'd leave it there.
What is your criteria for leaving/removing some of these methods?
There was a problem hiding this comment.
Ok, I reconsidered this. The error condition should be exceptions rather then something that people put into the expectations and we already have waitForRequest/Response methods so adding waitForRequestFailed would just confuse people. There are no tests right now that use wait for frame attached/detached, so removing those too. Let's add them if there if there our clients ask for them.
|
Merged with python's docs, corresponding playwright.dev change: microsoft/playwright.dev#108 |
|
|
||
| ## method: WebSocket.waitForFrameReceived | ||
| * langs: csharp, java | ||
| - returns: <[WebSocketFrame]> |
There was a problem hiding this comment.
What is WebSocketFrame? I see [string]|[Buffer] above.
There was a problem hiding this comment.
There is no way to defined such type union in java so I use a dedicated type for that. Will be happy to change that to something more elegant, let's discuss offline.
No description provided.