devops: start publishing canary at midnight every day #5343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
force-pushed
the
start-publishing-canary-at-midnight-every-day
branch
from
4691667
to
a662e2b
Compare
|
We still need driver per commit, does it only slow down publishing npms? |
dgozman
reviewed
Feb 7, 2021
| @@ -48,9 +48,6 @@ fi | |||
|
|
|||
| NPM_PUBLISH_TAG="next" | |||
|
|
|||
| if [[ $1 == "--tip-of-tree" ]]; then | |||
There was a problem hiding this comment.
git status check above fails if you update version beforehand.
utils/build/update_canary_version.js
Outdated
| }).toString('utf8').trim(); | ||
| packageJSON.version = `${packageJSON.version}-${timestamp}000`; | ||
| } else { | ||
| throw new Error('This script must be run with either --timestamp or --current-date parameter'); |
There was a problem hiding this comment.
nit: wrong arguments in the message
| const month = ['jan', 'feb', 'mar', 'apr', 'may', 'jun', 'jul', 'aug', 'sep', 'oct', 'nov', 'dec'][date.getMonth()]; | ||
| const day = date.getDate(); | ||
| const year = date.getFullYear(); | ||
| packageJSON.version = `${packageJSON.version}-alpha-${month}-${day}-${year}`; |
There was a problem hiding this comment.
Just curious, why do we need "alpha"?
There was a problem hiding this comment.
just to ensure that all there versions go before all others (there's alphabetical version sorting)
We can try driver-per-day, as long as we roll languages in advance 😄 |
This patch: - starts publishing canary version of driver & NPM package at 00:10AM UTC - canary versions are published from default (`master`) branch and are named with a date. E.g. for a version publsihed on Feb 5, 2021, the version would be `1.8.0-alpha-feb-5-2021` - release versions are still published on every commit and have the regular commit timestamp suffix.
aslushnikov
force-pushed
the
start-publishing-canary-at-midnight-every-day
branch
from
a662e2b
to
79b7be0
Compare
dgozman
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
master) branch and isnamed with a date. E.g. for a version published on Feb 5, 2021, the
version would be
1.8.0-alpha-feb-5-2021regular commit timestamp suffix