Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codegen): improve selector generation #5364

Merged
merged 1 commit into from Feb 9, 2021
Merged

feat(codegen): improve selector generation #5364

merged 1 commit into from Feb 9, 2021

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Feb 8, 2021

  • Snap to buttons, inputs, selects, etc.
  • Try <label> selector in addition to the element.
  • Use parent selectors when needed.
  • Remove xpath fallback as it should be covered with css.

@dgozman
feat(codegen): improve selector generation
59e9651 
- Snap to buttons, inputs, selects, etc.
- Try `<label>` selector in addition to the element.
- Use parent selectors when needed.
- Remove xpath fallback as it should be covered with css.
@dgozman dgozman marked this pull request as ready for review February 9, 2021 03:51
@dgozman dgozman merged commit 0871a9c into microsoft:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dgozman