Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add basic end-to-end driver test #5426

Merged
merged 1 commit into from Feb 12, 2021
Merged

test: add basic end-to-end driver test #5426

merged 1 commit into from Feb 12, 2021

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Feb 12, 2021

  • Introduce internal "out of process" start()/stop() mode.
  • This mode is used both in regular tests and installation tests.
  • Emulate basic driver installation, browser download and running.

This should prevent future regressions like microsoft/playwright-python#494.

aslushnikov
aslushnikov approved these changes Feb 12, 2021
View reviewed changes
Copy link
Collaborator

@aslushnikov aslushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: i'd consider moving outofprocess.ts out of src to avoid shipping it to users, but it's tiny so it's optional

@dgozman
test: add basic end-to-end driver test
efe9e78 
- Introduce internal "out of process" start()/stop() mode.
- This mode is used both in regular tests and installation tests.
- Emulate basic driver installation, browser download and running.
@dgozman dgozman merged commit 3e7b8e3 into microsoft:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslushnikov aslushnikov aslushnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgozman @aslushnikov