feat(inspector): instrument wait for event #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
wfl3
branch
2 times, most recently
from
b06b161
to
d7cc548
Compare
dgozman
approved these changes
Feb 14, 2021
| @@ -64,7 +87,7 @@ export class Waiter { | |||
|
|
|||
| log(s: string) { | |||
| this._logs.push(s); | |||
| debugLogger.log('api', s); | |||
| this._channelOwner._waitForEventInfoLog(this._waitId, s); | |||
There was a problem hiding this comment.
This makes me think whether we can now remove api call logging from the client and emit it from the server? We should have all the information already.
There was a problem hiding this comment.
Yes, that's the goal. We need to add api call name to metadata for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.