Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dotnet): alias for dblclick in C# #5899

Merged
merged 2 commits into from Apr 6, 2021
Merged

chore(dotnet): alias for dblclick in C# #5899

merged 2 commits into from Apr 6, 2021

Conversation

kblok
Copy link
Contributor

@kblok kblok commented Mar 22, 2021

DblClick is better in pascal case

@kblok
chore(dotnet): make dblclick names csharp friendly
73e2ef9 
DblClick is better in pascal case
@avodovnik avodovnik changed the title chore(dotnet): make dblclick names csharp friendly chore(dotnet): alias for dblclick in C# Mar 22, 2021
@kblok kblok mentioned this pull request Mar 22, 2021
Merged
avodovnik
avodovnik approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@avodovnik avodovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yury-s I wonder if we should do the same thing here that we did with similar changes, make the default correct case, and alias for Python and JavaScript... this seems like a change that should be in Java too, no?

@avodovnik avodovnik requested a review from yury-s March 24, 2021 14:27
@avodovnik avodovnik merged commit ee39642 into microsoft:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avodovnik avodovnik avodovnik approved these changes

@yury-s yury-s Awaiting requested review from yury-s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kblok @avodovnik