test: extract tests for webkit provisional page #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -181,6 +181,9 @@ module.exports.describe = ({testRunner, product, playwrightPath}) => { | |||
| testRunner.loadTests(require('./features/permissions.spec.js'), testOptions); | |||
| } | |||
|
|
|||
| if (WEBKIT) { | |||
| testRunner.loadTests(require('./webkit/provisional.spec.js'), testOptions); | |||
There was a problem hiding this comment.
I like that we extracted these into their own file. Is there any reason we cant run them for other browsers? While we don't do provisional stuff in the protocol for chromium, it still often had similar bugs related to process swapping.
There was a problem hiding this comment.
Chromium does not resolve most protocol promises during navigation, and that's unlikely to change. Basically, we are not testing API here (because we cannot make it work everywhere), but specifically webkit implementation.
There was a problem hiding this comment.
So we should eventually upstream these into protocol tests in webkit itself.
JoelEinbinder
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.