fix(screencast): properly stop screencast on context closure #6146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Apr 8, 2021
| @@ -93,10 +93,6 @@ export abstract class BrowserContext extends SdkObject { | |||
| } | |||
| this._closedStatus = 'closed'; | |||
| this._downloads.clear(); | |||
| for (const [id, video] of this._browser._idToVideo) { | |||
There was a problem hiding this comment.
Why removing this? It does not hurt to cleanup, just in case something went wrong and we leaked stuff.
There was a problem hiding this comment.
Because this is the reason the test is failing. The video gets removed from the map and after that reportFinished fails.
dgozman
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 'should capture static page in persistent context' in Chromium Headful.