docs(python): add Error base class #6315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
docs/python-error-class
branch
from
58e8306
to
082da15
Compare
mxschmitt
force-pushed
the
docs/python-error-class
branch
from
082da15
to
b04fde1
Compare
yury-s
reviewed
Apr 26, 2021
| @@ -0,0 +1,26 @@ | |||
| # class: Error | |||
There was a problem hiding this comment.
shouldn't it be more specific like PlaywrightError so that it's easier to tell what kind of error is being caught?
There was a problem hiding this comment.
it should be that would result in a breaking change on Playwright Python side.
There was a problem hiding this comment.
yury-s
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.