feat(types): export ScreenshotOptions #6419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
approved these changes
May 5, 2021
dgozman
reviewed
May 5, 2021
utils/generate_types/exported.json
Outdated
| @@ -6,5 +6,6 @@ | |||
| "BrowserNewContextOptions": "BrowserContextOptions", | |||
| "BrowserNewContextOptionsViewport": "ViewportSize", | |||
| "BrowserNewContextOptionsGeolocation": "Geolocation", | |||
| "BrowserNewContextOptionsHttpCredentials": "HTTPCredentials" | |||
| "BrowserNewContextOptionsHttpCredentials": "HTTPCredentials", | |||
| "PageScreenshotOptions": "ScreenshotOptions", | |||
There was a problem hiding this comment.
I think this is a bit confusing, because elementHandle.screenshot does not take these options (it is missing the clip). WDYT?
There was a problem hiding this comment.
PageScreenshotOptions?
JoelEinbinder
force-pushed
the
export_screenshot_options
branch
from
3b95e1d
to
3f76e33
Compare
sand4rt
pushed a commit
to sand4rt/playwright
that referenced
this pull request
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exports
ScreenshotOptionsas a new type. Screenshots have a fairly complicated set of options, and they are likely to be exposed by libraries that wrap Playwright.fixes #4752