Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): prevent new-lines on CI/without TTY #6703

Merged
merged 1 commit into from May 25, 2021

Conversation

mxschmitt
Copy link
Member

Before it resulted in:

chromium v879910 downloaded to /home/runner/.cache/ms-playwright/chromium-879910

firefox v1261 downloaded to /home/runner/.cache/ms-playwright/firefox-1261

webkit v1481 downloaded to /home/runner/.cache/ms-playwright/webkit-1481

ffmpeg v1005 downloaded to /home/runner/.cache/ms-playwright/ffmpeg-1005

now it results in

chromium v879910 downloaded to /home/runner/.cache/ms-playwright/chromium-879910
firefox v1261 downloaded to /home/runner/.cache/ms-playwright/firefox-1261
webkit v1481 downloaded to /home/runner/.cache/ms-playwright/webkit-1481
ffmpeg v1005 downloaded to /home/runner/.cache/ms-playwright/ffmpeg-1005

This was caused because the progressBar.tick function internally wrote a new line when a download of a browser/ffmpeg was completed. With this change we never invoke the progress-bar when there is no TTY on the stderr, thats the output which the progress-bar uses.

Affected was mostly CI/bots.

@mxschmitt mxschmitt requested a review from dgozman May 22, 2021 16:22
@dgozman dgozman requested a review from aslushnikov May 22, 2021 18:41
Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this will fix the 3 new lines printed to stderr when installing browsers via driver, it's sowewhat annoying to see it in java on CI

@mxschmitt mxschmitt merged commit 39a8abd into microsoft:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants