docs(class-page.md): Add additional clarification on requestFailed event #6724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
reviewed
May 24, 2021
gboer
force-pushed
the
gboer-requestfailed-doc
branch
2 times, most recently
from
768b693
to
4fa9a6f
Compare
yury-s
approved these changes
May 25, 2021
|
Please run |
The current note makes it look like only special responses are considered 'successful' requests, but any request that completes - no matter how - will never show up in the requestFailed event.
gboer
force-pushed
the
gboer-requestfailed-doc
branch
from
4fa9a6f
to
d51853d
Compare
|
|
|
Thanks, should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current note makes it look like only special responses are considered 'successful' requests, but any request that completes - no matter how - will never show up in the requestFailed event.