chore: fix missing device definitions

[sotayamashita]

Background

related to #606

How has this been tested?

1. Clone the repository including this patch
2. Create a sample project
3. Install local module as npm package with npm install -S /absolute-path/to/playwright
   package.json should be like this:

   "dependencies": {
       "playwright-core": "file:/path/to/playwright"
   }

4. Create a main.js with following code:

   const devices = require("playwright-core").devices
   
   const deviceMap = new Map();
   for (const device of devices) {
     deviceMap.set(device.name, device);
   }
   
   for (const name of deviceMap.keys()) {
     if (name.endsWith(" landscape")) continue;
     const landscapeName = `${name} landscape`;
     if (!deviceMap.has(landscapeName)) {
       const landscapeDevice = deviceMap.get(name);
       const {width, height} = landscapeDevice.viewport;
       landscapeDevice.name = landscapeName;
       landscapeDevice.viewport.width = height;
       landscapeDevice.viewport.height = width;
       console.log(`Missing device for "${landscapeName}", expected: ${JSON.stringify(landscapeDevice,     null, 2)}`);
     }
   }

5. It should not output log.

Question

• I think it has a spec it to to avoid same error. What do you think?

[msftclas]

All CLA requirements met.

[aslushnikov]

Thank you!

I think it has a spec it to to avoid same error. What do you think?

Let's rely on code reviews for now - I think there are some devices that don't have landscape, so adding a lint check is not that straightforward