Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test-runner): accept relative paths for outputDir #7149

Merged
merged 2 commits into from Jun 15, 2021

Conversation

JoelEinbinder
Copy link
Contributor

fixes #7124

@mxschmitt
Copy link
Member

Can we use test-runner as a feature-scope in the commit-message?

@JoelEinbinder JoelEinbinder changed the title fix(pwt): accept relative paths for outputDir fix(test-runner): accept relative paths for outputDir Jun 15, 2021
@JoelEinbinder
Copy link
Contributor Author

Can we use test-runner as a feature-scope in the commit-message?

That's what we settled on? Sure.

@JoelEinbinder JoelEinbinder merged commit 4c2a3fb into microsoft:master Jun 15, 2021
aslushnikov pushed a commit to aslushnikov/playwright that referenced this pull request Jun 25, 2021
aslushnikov added a commit that referenced this pull request Jun 25, 2021
PR #7149 SHA 4c2a3fb

Co-authored-by: Joel Einbinder <joel.einbinder@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test Runner] config.outputDir must be an absolute path
2 participants