fix(playwright-test): have the proper default export #7328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
approved these changes
Jun 25, 2021
mxschmitt
approved these changes
Jun 25, 2021
aslushnikov
approved these changes
Jun 25, 2021
aslushnikov
pushed a commit
to aslushnikov/playwright
that referenced
this pull request
Jun 25, 2021
…7328) There are 3 ways to import `@playwright/test` library in the modern Node.js ecosystem: - Using `require`: works great, this patch doesn't change it - Using `import` statement from `.mjs` file - we have wrong `default` for @playwright/test that should be a `test`. This is what test checks for - Using `import test from '@playwright/test'` from `.ts` file - was broken because TypeScript thought it's a CJS module, whereas it's a ESM module in reality. Also, typescript types import from `.d.ts` file was broken because we had no default export (`export *` syntax does not export default).
aslushnikov
added a commit
that referenced
this pull request
Jun 25, 2021
) There are 3 ways to import `@playwright/test` library in the modern Node.js ecosystem: - Using `require`: works great, this patch doesn't change it - Using `import` statement from `.mjs` file - we have wrong `default` for @playwright/test that should be a `test`. This is what test checks for - Using `import test from '@playwright/test'` from `.ts` file - was broken because TypeScript thought it's a CJS module, whereas it's a ESM module in reality. Also, typescript types import from `.d.ts` file was broken because we had no default export (`export *` syntax does not export default). Co-authored-by: Joel Einbinder <joel.einbinder@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 ways to import
@playwright/testlibrary in the modern Node.js ecosystem:require: works great, this patch doesn't change itimportstatement from.mjsfile - we have wrongdefaultfor @playwright/test that should be atest. This is what test checks forimport test from '@playwright/test'from.tsfile - was broken because TypeScript thought it's a CJS module, whereas it's a ESM module in reality.Also, typescript types import from
.d.tsfile was broken because we had no default export (export *syntax does not export default).