chore: nicer message to install dependencies #7715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we know how to install all dependencies, then we should recommend a Playwright CLI one-liner to install dependencies. References microsoft#7682
mxschmitt
approved these changes
Jul 19, 2021
src/utils/dependencies.ts
Outdated
| `Host system is missing a few dependencies to run browsers.`, | ||
| `Please install them with the following command:`, | ||
| ``, | ||
| ` sudo npx playwright install-deps`, |
There was a problem hiding this comment.
show sudo conditional?
const needsSudo = process.platform !== 'win32 && process.getuid() !== 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we know how to install all dependencies, then we should recommend
a Playwright CLI one-liner to install dependencies.
References #7682