Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change vendor package exports #818

Merged

Conversation

aslushnikov
Copy link
Collaborator

This patch changes top-level exports for the vendor-specific
packages:

  • playwright-chromium: now exports an object with a single chromium
    field
  • playwright-wekbit: now exports an object with a single webkit
  • playwright-firefox: now exports an object with a single firefox

Fixes #814

This patch changes top-level exports for the vendor-specific
packages:
- `playwright-chromium`: now exports an object with a single `chromium`
field
- `playwright-wekbit`: now exports an object with a single `webkit`
- `playwright-firefox`: now exports an object with a single `firefox`

Fixes microsoft#814
@pavelfeldman
Copy link
Member

Let's leave { devices } there as well.

@aslushnikov aslushnikov merged commit cea036a into microsoft:master Feb 3, 2020
@aslushnikov aslushnikov deleted the change-vendor-package-exports branch February 3, 2020 22:24
sand4rt pushed a commit to sand4rt/playwright that referenced this pull request Dec 21, 2022
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] playwright-chromium and playwright have different export signatures
2 participants