feat(route): rename method, add response option #8386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
commented
Aug 24, 2021
| res.end('Woo-hoo'); | ||
| }); | ||
| const page2 = await page.context().newPage(); | ||
| const sampleResponse = await page2.goto(`${server.PREFIX}/sample`); |
There was a problem hiding this comment.
We cannot use page.goto() here (need to create page2) to create sampleResponse as in that case sampleResponse.body() would throw because page would already have started navigating to another URL. Perhaps we should bail out if we cannot retrieve response body of the response which is passed or only accept intercepted response.
pavelfeldman
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes to the response interception API:
Route._continueToRequestRoute.fulfill()#1774