feat(launch): introduce client, server & persistent launch modes (2) #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
defaultContext2
branch
3 times, most recently
from
664f226
to
ec3c20d
Compare
dgozman
approved these changes
Feb 5, 2020
src/server/chromium.ts
Outdated
| @@ -100,10 +115,10 @@ export class Chromium implements BrowserType { | |||
| } | |||
|
|
|||
| const usePipe = chromeArguments.includes('--remote-debugging-pipe'); | |||
| if (usePipe && isServer) | |||
| throw new Error(`Argument "--remote-debugging-pipe" is not compatible with the launchBrowserApp.`); | |||
| if (usePipe && launchType === 'server') | |||
There was a problem hiding this comment.
Let's completely ban both --remote-debugging-pipe and --remote-debugging-port.
| @@ -47,7 +47,7 @@ module.exports.describe = function({testRunner, expect, playwright, defaultBrows | |||
| describe('ChromiumHeadful', function() { | |||
| it('background_page target type should be available', async() => { | |||
| const browserWithExtension = await playwright.launch(extensionOptions); | |||
There was a problem hiding this comment.
Let's do launchPersistent here.
test/launcher.spec.js
Outdated
| expect(fs.readdirSync(userDataDir).length).toBeGreaterThan(0); | ||
| await browser.close(); | ||
| await browserContext.close(); | ||
| expect(fs.readdirSync(userDataDir).length).toBeGreaterThan(0); | ||
| // This might throw. See https://github.com/GoogleChrome/puppeteer/issues/2778 | ||
| await rmAsync(userDataDir).catch(e => {}); | ||
| }); | ||
| it('userDataDir argument', async({server}) => { |
There was a problem hiding this comment.
Drop this one, it's equivalent to the previous.
test/playwright.spec.js
Outdated
| @@ -93,22 +93,22 @@ module.exports.describe = ({testRunner, product, playwrightPath}) => { | |||
| describe('Browser', function() { | |||
| beforeAll(async state => { | |||
| state.browser = await playwright.launch(); | |||
There was a problem hiding this comment.
Did you lose defaultBrowserOptions here?
pavelfeldman
force-pushed
the
defaultContext2
branch
from
ec3c20d
to
85b0404
Compare
sand4rt
pushed a commit
to sand4rt/playwright
that referenced
this pull request
Dec 21, 2022
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.